Zachary Hopkins

Great plugin, small change

Thanks for the extremely useful plugin! I've found a scenario in which the plugin reports a warning/error condition as unknown. The following output is given by the plugin, ===== Unkown response from SMcli: " The following failures have been found: Insufficient Cache Backup Device Capacity Storage Subsystem: [[Array Name]] Component reporting problem: Not Available Status: Not Available Location: Controller/Drive enclosure, Controller in slot A Component requiring service: Controller in slot A Service action (removal) allowed: No Service action LED on component: Yes " ===== I think that modifying line 114 to include "Insufficient" under the warning search would be a reasonable change. Would you concur? == Changed Code === case "$RESULT" in *optimal*) echo $RESULT echo "OK" exit $STATE_OK ;; *failure*) case "$RESULT" in *failed*|*Failed*|*Unreadable*) echo $RESULT echo "CRITICAL" exit $STATE_CRITICAL ;; *preferred*|*Preferred*|*Expiration*|*Insufficient*) echo $RESULT echo "WARNING" exit $STATE_WARNING ;; *) echo "Unkown response from SMcli: " $RESULT "" echo "UNKNOWN" exit $STATE_UNKNOWN ;; esac ;; ====

Reviewed 11 years ago