Kalju S

Good start, but some refinement would help

The plugin seems to do a decent job at picking up the correct information from the iDRAC controller. However, at least in my experiments the no_alerts option seemed to be switched on by default and that means that even though the HW issues (like an unplugged PS) were detected, they did not trigger a Nagios alert. For example: $ ./check_idrac -f ./check_idrac.conf -H 10.0.0.1 -w ps PS 1: CRITICAL, Volt I/O: 264 V/(N/A) V, Current: (N/A) A, Watt I/O: 900.0 W/750.0 W PS 2: OK, Volt I/O: 264 V/246.0 V, Current: 0.4 A, Watt I/O: 900.0 W/750.0 W $ echo $? 0 So the correct exit code was not set. I could find no other way to fix it than to change the code: 179c179 opts.no_alert = True Also the PS and PU options should be better implemented / documented. Both, the wat-warn and the wat-crit need to be defined, otherwise you'll get a parsing error: $ ./check_idrac -f ./check_idrac.conf -H 10.0.0.1 -w ps --wat-warn=100,500 Error parsing threshold. I believe the options should be parsed in separate code blocks or at least the error should be more precise. (This specific code starts on the line 256). Thank you for the plugin and hope these issues will get addressed to make it a little bit more user friendly.

Reviewed 11 years ago