Chux

The script makes assumptions about login details for squid

The script has a good conceptual bases .. and pulls in squid info using 'squidclient -h $HOSTADDRESS$ -p SQUIDPORT mgr:info' .. But it makes an assumption that users of the script would first check required ACLs for the squid deployment, and modifying the script accordingly .. although it does keep silent on this. You get the 'uninitialized value' warning (mentioned above) when the squidclient command fails because the script is not checking its return value before proceeding to attempt to parse the output of squidclient .. Still great that the author shared this .. and it can cleaned up and adapted relatively easily. > Use of uninitialized value in sprintf at /usr/local/share/perl5/Nagios/Plugin/Performance.pm

Reviewed 12 years ago